Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for issue when there are multiple aggregates with the same data field and aggregation operation #9320

Merged
merged 1 commit into from
Jul 28, 2024
Merged

fix: for issue when there are multiple aggregates with the same data field and aggregation operation #9320

merged 1 commit into from
Jul 28, 2024

Conversation

JessamineQ
Copy link
Contributor

PR Description

Fixes #6184.
When there are multiple elements in AggregateTransform with the same data field and aggregation operation, the code is currently only keeping the first output field name.

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

@JessamineQ JessamineQ requested a review from a team as a code owner April 22, 2024 23:30
@JessamineQ JessamineQ changed the title fix: for issue when there are multiple aggregates with the same data field and aggregation operation fix: for issue when there are multiple aggregates with the same data field and aggregation operation Apr 22, 2024
@domoritz
Copy link
Member

domoritz commented Jul 28, 2024 •
edited
Loading

Thank you for the pull request and your patience!

@domoritz domoritz merged commit da84469 into vega:main Jul 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

errorband_tooltip example is empty
2 participants
@JessamineQ @domoritz